Comments on: Enhancements to subModal

By: Todd Huss

Todd Huss — Mon, 03 Jul 2006 17:29:33 +0000

I’m glad so many people are enjoying my submodal derivative! The support requests have become time consuming though and mostly for issues that aren’t problems with submodal. So I’m shutting off comments and only accepting patches/fixes now. If you’re smart enough to be using submodal then you’re smart enough to fix it and test the fix across browsers.

If you think you’ve fixed a bug with submodal create a patch file for it and email it to thuss at gabrito dot com and I’ll incorporate it into the main distribution!

By: Tom

Tom — Fri, 30 Jun 2006 11:02:39 +0000

For those who want to see my problem in action …
Have a look at:
http://www.lostonearth.nl/tools/filebrowser/

By: Tom

Tom — Wed, 28 Jun 2006 09:32:37 +0000

Hello,

This submodal is great and ideal to integrated it with my CMS as a file-selection tool. Unfortunatly I have a problem in FireFox (1.5.0.4). Any help would be greatly appreciated.

The case:
In the parent window I have a form with a textfield and a button. When the button is pressed the submodal is loaded and filled with directory listing and available files (all HTML). When user clicks on a file the parent.form.textfield is updated and submodal is closed.

The problem:
When the button is pressed to load submodal, the submodal loading.html is shown for less than a second, but when the actual ‘fileselection page’ is loaded, the parent.form is automatically submitted and submodal is closed. These last two actions are unwanted.
In IE the problem does NOT occur.

Any hints?

By: vadim

vadim — Mon, 26 Jun 2006 01:58:52 +0000

Hi V,

This solved my problem, I had to both change the doctype of my page, and uncomment
addEvent(window, “scroll”, centerPopWin);

Thanks a lot,

Vadim

By: v

Sat, 24 Jun 2006 09:00:38 +0000

Sorry for the above comment:

Btw heres the doctype that should work

"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">

And this is what I’m using

By: v

Sat, 24 Jun 2006 08:51:32 +0000

Todd
U’v done a nice job packing/upgrading this script.

vadim
Have you check the doctype of your page.
The doctype below will solve your problem I guess.

Unfortunately for me it wont because I have no control over it.
Below is the doctype of my pages.

Any Idea how to achive the save looks/bahavior with this doctype?
Thanks

By: Jeff

Jeff — Fri, 16 Jun 2006 20:53:38 +0000

Todd,

I am playing around with your submodal code on a .NET webform and after some postbacks it seems to randomly make the sumodal form the new main form (like doing an “_top” in the call). Have you ever seen this, or have and tips on where to debug to catch what could be causing this?

Thanks,

Jeff

By: vadim

vadim — Tue, 13 Jun 2006 23:54:38 +0000

Todd,
I will definitely try to debug this.
You gave me a direction to investigate and I think the problem is in onscroll event because resizing works, it’s when I scroll down the image won’t position itself in the center of the page but rather slides up with the rest of the page.

Thanks a lot

Vadim

By: Todd Huss

Todd Huss — Tue, 13 Jun 2006 20:55:11 +0000

Hi Vadim, I’ve seen errors like that occur when other javascript on the page is conflicting with subModal or if you have a javascript error somewhere on your page. There’s a line in submodalsource.js that add’s an event to redraw the submodal window when the browser is resized or scrolled:

addEvent(window, “resize”, centerPopWin);

It sounds to me like it’s not running. Two suggestions:

1. In Firefox go to Tools -> Javascript Console and look for any Javascript errors on your page. You can ignore CSS errors.

2. Install the Firebug plugin for Firefox that will let you debug your Javascript and give you a green indicator if everything looks OK on the page:

http://www.joehewitt.com/software/firebug/

By: vadim

vadim — Tue, 13 Jun 2006 20:04:31 +0000

Hi Todd,

Thanks a lot for your reply.
Yes, your site looks OK in my browser (it’s IE6), and the submodal window popups in a proper place all the time, and when I scroll your site the window is positioned in the middle (except for cases when the browser is not maximized then window on your site does not reposition itself when the main window is scrolled), but anyway it looks very good.
For some reason in my app the popup is always positioned at the top of the browser window and the blueish div covers only the top part of the window, if I scroll the window down, the popup does not reposition itself. I just use the latest downloaded code from http://www.subimage.com/dhtml/subModal.
Do you have any suggestions of what might be causing this on my side?

Thanks again

Vadim